WPT lint doesn't always trigger correctly

#37991
servo
servo
servo

Issue Details

27 days ago
No assignee
A-infrastructureA-testingL-python
View on GitHub
jdmjdm
opened 27 days ago
Author

https://github.com/servo/servo/pull/37637 merged without any errors reported by the WPT lint that runs as part of test-tidy. Meanwhile, when I run the command locally on the branch on my macOS machine:

 ➤  Linting WPT suite (tests)...
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 1: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 2: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 3: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 4: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 5: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 6: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 7: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 8: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 9: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 10: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 11: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 12: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 13: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 14: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 15: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 16: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 17: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 18: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 19: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 20: Test-file line ends with CR (U+000D) character (CR AT EOL)
  | html/semantics/embedded-content/the-img-element/animated-webp-update.tentative.html:: 21: Test-file line ends with CR (U+000D) character (CR AT EOL)

This matches what happened in the upstream PR, too: https://github.com/web-platform-tests/wpt/pull/53620 The end result is that the upstream PR failed to merge after the Servo PR merged, because the CI checks failed.

Could this be platform-specific? @rayguo17 What output do you get if you run ./mach test-tidy on your branch?

I Want to Work on This Issue